patchew complained, so something like this on top
diff --git a/qapi/run-state.json b/qapi/run-state.json index a93f6fea5c..a148088252 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -328,21 +328,19 @@ ## { 'enum': 'GuestPanicInformationType', 'data': [ 'hyper-v', 's390' ] } ## # @GuestPanicInformation: # # Information about a guest panic # -# @hyper-v: hyper-v guest panic information -# -# @s390: s390 guest panic information (Since: 2.12) +# @type: Crash type that defines the hypervisor specific information # # Since: 2.9 ## {'union': 'GuestPanicInformation', 'base': {'type': 'GuestPanicInformationType'}, 'discriminator': 'type', 'data': { 'hyper-v': 'GuestPanicInformationHyperV', 's390': 'GuestPanicInformationS390' } } seems to fix it. On 02/02/2018 03:51 PM, Eric Blake wrote: > On 02/02/2018 08:37 AM, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the related commits. We will detect several crash >> reasons, with the "disabled wait" being the most important one, since >> this is used by all s390 guests as a "panic like" notification. >> >> Demonstrate these ways with examples as follows. >> >> 1. crash-information QOM property; > >> >> Co-authored-by: Jing Liu <liuj...@linux.vnet.ibm.com> >> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> >> --- >> qapi/run-state.json | 29 ++++++++++++++++++++++++-- > > QAPI changes look reasonable; I'll leave the review of the > target-specific code to those more familiar with the target. >