Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1e781206be fpu/softfloat: re-factor sqrt e685ea8dc4 fpu/softfloat: re-factor compare 63b87bcb69 fpu/softfloat: re-factor minmax 669591c216 fpu/softfloat: re-factor scalbn 2ed6c7c81d fpu/softfloat: re-factor int/uint to float d1bd89624f fpu/softfloat: re-factor float to int/uint bc1a994506 fpu/softfloat: re-factor round_to_int 6485285f24 fpu/softfloat: re-factor muladd e385a48184 fpu/softfloat: re-factor div 92464a80c3 fpu/softfloat: re-factor mul ffd17dee64 fpu/softfloat: re-factor add/sub 7815017f4b fpu/softfloat: define decompose structures 30d6d92cb4 fpu/softfloat: move the extract functions to the top of the file 51361e8312 fpu/softfloat: improve comments on ARM NaN propagation c585bf8e1d include/fpu/softfloat: add some float16 constants e5feca0066 include/fpu/softfloat: implement float16_set_sign helper 28e817f796 include/fpu/softfloat: implement float16_chs helper fecbf8dcc9 include/fpu/softfloat: implement float16_abs helper 294fc6dd01 target/*/cpu.h: remove softfloat.h b712e8fbb6 fpu/softfloat-types: new header to prevent excessive re-builds 694133665c include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES cf60e4d868 fpu/softfloat: implement float16_squash_input_denormal === OUTPUT BEGIN === Checking PATCH 1/22: fpu/softfloat: implement float16_squash_input_denormal... Checking PATCH 2/22: include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES... Checking PATCH 3/22: fpu/softfloat-types: new header to prevent excessive re-builds... Checking PATCH 4/22: target/*/cpu.h: remove softfloat.h... Checking PATCH 5/22: include/fpu/softfloat: implement float16_abs helper... Checking PATCH 6/22: include/fpu/softfloat: implement float16_chs helper... Checking PATCH 7/22: include/fpu/softfloat: implement float16_set_sign helper... Checking PATCH 8/22: include/fpu/softfloat: add some float16 constants... Checking PATCH 9/22: fpu/softfloat: improve comments on ARM NaN propagation... Checking PATCH 10/22: fpu/softfloat: move the extract functions to the top of the file... Checking PATCH 11/22: fpu/softfloat: define decompose structures... Checking PATCH 12/22: fpu/softfloat: re-factor add/sub... ERROR: space prohibited after that open parenthesis '(' #532: FILE: fpu/softfloat.c:2568: + aSign = extractFloat32Sign( a ); ERROR: space prohibited before that close parenthesis ')' #532: FILE: fpu/softfloat.c:2568: + aSign = extractFloat32Sign( a ); ERROR: space prohibited after that open parenthesis '(' #563: FILE: fpu/softfloat.c:2571: + bSign = extractFloat32Sign( b ); ERROR: space prohibited before that close parenthesis ')' #563: FILE: fpu/softfloat.c:2571: + bSign = extractFloat32Sign( b ); ERROR: space prohibited after that open parenthesis '(' #565: FILE: fpu/softfloat.c:2573: + if ( aExp == 0xFF ) { ERROR: space prohibited before that close parenthesis ')' #565: FILE: fpu/softfloat.c:2573: + if ( aExp == 0xFF ) { ERROR: space prohibited after that open parenthesis '(' #566: FILE: fpu/softfloat.c:2574: + if ( aSig || ( ( bExp == 0xFF ) && bSig ) ) { ERROR: space prohibited before that close parenthesis ')' #566: FILE: fpu/softfloat.c:2574: + if ( aSig || ( ( bExp == 0xFF ) && bSig ) ) { ERROR: space prohibited after that open parenthesis '(' #571: FILE: fpu/softfloat.c:2577: + if ( ( bExp | bSig ) == 0 ) { ERROR: space prohibited before that close parenthesis ')' #571: FILE: fpu/softfloat.c:2577: + if ( ( bExp | bSig ) == 0 ) { ERROR: space prohibited after that open parenthesis '(' #577: FILE: fpu/softfloat.c:2581: + return packFloat32( zSign, 0xFF, 0 ); ERROR: space prohibited before that close parenthesis ')' #577: FILE: fpu/softfloat.c:2581: + return packFloat32( zSign, 0xFF, 0 ); ERROR: space prohibited after that open parenthesis '(' #585: FILE: fpu/softfloat.c:2583: + if ( bExp == 0xFF ) { ERROR: space prohibited before that close parenthesis ')' #585: FILE: fpu/softfloat.c:2583: + if ( bExp == 0xFF ) { ERROR: space prohibited after that open parenthesis '(' #597: FILE: fpu/softfloat.c:2587: + if ( ( aExp | aSig ) == 0 ) { ERROR: space prohibited before that close parenthesis ')' #597: FILE: fpu/softfloat.c:2587: + if ( ( aExp | aSig ) == 0 ) { ERROR: space prohibited after that open parenthesis '(' #788: FILE: fpu/softfloat.c:2591: + return packFloat32( zSign, 0xFF, 0 ); ERROR: space prohibited before that close parenthesis ')' #788: FILE: fpu/softfloat.c:2591: + return packFloat32( zSign, 0xFF, 0 ); total: 18 errors, 0 warnings, 996 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 13/22: fpu/softfloat: re-factor mul... Checking PATCH 14/22: fpu/softfloat: re-factor div... Checking PATCH 15/22: fpu/softfloat: re-factor muladd... Checking PATCH 16/22: fpu/softfloat: re-factor round_to_int... WARNING: line over 80 characters #118: FILE: fpu/softfloat.c:1261: + inc = ((a.frac & roundeven_mask) != frac_lsbm1 ? frac_lsbm1 : 0); total: 0 errors, 1 warnings, 353 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 17/22: fpu/softfloat: re-factor float to int/uint... ERROR: space prohibited after that open parenthesis '(' #716: FILE: fpu/softfloat.c:3420: + if ( ( ( extractFloat32Exp( a ) == 0xFF ) && extractFloat32Frac( a ) ) ERROR: space prohibited before that close parenthesis ')' #716: FILE: fpu/softfloat.c:3420: + if ( ( ( extractFloat32Exp( a ) == 0xFF ) && extractFloat32Frac( a ) ) ERROR: space prohibited after that open parenthesis '(' #717: FILE: fpu/softfloat.c:3421: + || ( ( extractFloat32Exp( b ) == 0xFF ) && extractFloat32Frac( b ) ) ERROR: space prohibited before that close parenthesis ')' #717: FILE: fpu/softfloat.c:3421: + || ( ( extractFloat32Exp( b ) == 0xFF ) && extractFloat32Frac( b ) ) ERROR: space prohibited after that open parenthesis '(' #738: FILE: fpu/softfloat.c:3429: + aSign = extractFloat32Sign( a ); ERROR: space prohibited before that close parenthesis ')' #738: FILE: fpu/softfloat.c:3429: + aSign = extractFloat32Sign( a ); ERROR: space prohibited after that open parenthesis '(' #739: FILE: fpu/softfloat.c:3430: + bSign = extractFloat32Sign( b ); ERROR: space prohibited before that close parenthesis ')' #739: FILE: fpu/softfloat.c:3430: + bSign = extractFloat32Sign( b ); WARNING: line over 80 characters #742: FILE: fpu/softfloat.c:3433: + if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 ); ERROR: spaces required around that '<<' (ctx:VxV) #742: FILE: fpu/softfloat.c:3433: + if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 ); ^ ERROR: space prohibited after that open parenthesis '(' #742: FILE: fpu/softfloat.c:3433: + if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 ); ERROR: space prohibited before that close parenthesis ')' #742: FILE: fpu/softfloat.c:3433: + if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 ); ERROR: trailing statements should be on next line #742: FILE: fpu/softfloat.c:3433: + if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 ); ERROR: braces {} are necessary for all arms of this statement #742: FILE: fpu/softfloat.c:3433: + if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 ); [...] ERROR: space prohibited after that open parenthesis '(' #743: FILE: fpu/softfloat.c:3434: + return ( av != bv ) && ( aSign ^ ( av < bv ) ); ERROR: space prohibited before that close parenthesis ')' #743: FILE: fpu/softfloat.c:3434: + return ( av != bv ) && ( aSign ^ ( av < bv ) ); ERROR: space prohibited after that open parenthesis '(' #803: FILE: fpu/softfloat.c:3450: + if ( ( ( extractFloat32Exp( a ) == 0xFF ) && extractFloat32Frac( a ) ) ERROR: space prohibited before that close parenthesis ')' #803: FILE: fpu/softfloat.c:3450: + if ( ( ( extractFloat32Exp( a ) == 0xFF ) && extractFloat32Frac( a ) ) ERROR: space prohibited after that open parenthesis '(' #804: FILE: fpu/softfloat.c:3451: + || ( ( extractFloat32Exp( b ) == 0xFF ) && extractFloat32Frac( b ) ) ERROR: space prohibited before that close parenthesis ')' #804: FILE: fpu/softfloat.c:3451: + || ( ( extractFloat32Exp( b ) == 0xFF ) && extractFloat32Frac( b ) ) total: 19 errors, 1 warnings, 1068 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 18/22: fpu/softfloat: re-factor int/uint to float... Checking PATCH 19/22: fpu/softfloat: re-factor scalbn... Checking PATCH 20/22: fpu/softfloat: re-factor minmax... Checking PATCH 21/22: fpu/softfloat: re-factor compare... Checking PATCH 22/22: fpu/softfloat: re-factor sqrt... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
