Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180209092524.31348-1-coh...@redhat.com
Subject: [Qemu-devel] [PULL 00/29] s390x: assorted updates

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   008a51bbb3..04bb7fe2bf  master     -> master
 * [new tag]               patchew/20180209092524.31348-1-coh...@redhat.com -> 
patchew/20180209092524.31348-1-coh...@redhat.com
Switched to a new branch 'test'
b1c1c1ec7c MAINTAINERS: add David as additional tcg/s390 maintainer
cc5290f37c MAINTAINERS: reorganize s390-ccw bios maintainership
1c617d5185 MAINTAINERS: add myself as overall s390x maintainer
a7560ae1a7 s390x/pci: use the right pal and pba in reg_ioat()
bade030c15 s390x/pci: fixup global refresh
c82c36e54d s390x/pci: fixup the code walking IOMMU tables
bf22d638fb s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility
f28d2a91cd s390x/cpumodel: allow zpci features in qemu model
34b0bd98bc s390x/tcg: wire up pci instructions
13b2bbce1d s390x/sclp: fix event mask handling
511c79770d s390x/flic: cache the common flic class in a central function
3cf760d263 s390x/kvm: cache the kvm flic in a central function
b2a1f04b81 s390x/tcg: cache the qemu flic in a central function
e531257b07 configure: s390x supports mttcg now
95d36d11c2 s390x/tcg: remove SMP warning
6c00754b2d s390x/tcg: STSI overhaul
3f35dc9a46 s390x: fix size + content of STSI blocks
e71c443e52 s390x/flic: optimize CPU wakeup for TCG
7d63a4ea2e s390x/flic: implement qemu_s390_clear_io_flic()
f6319e6bcb s390x/tcg: implement TEST PENDING INTERRUPTION
aa43e08adb s390x/flic: make floating interrupts on TCG actually floating
feaf5fd238 s390x/tcg: tolerate wrong wakeups due to floating interrupts
f445d494a8 s390x/flic: no need to call s390_io_interrupt() from flic
d501653bf4 s390x/flic: factor out injection of floating interrupts
e467b68d2f s390x/tcg: simplify machine check handling
5bf66b4828 s390x/tcg: simplify lookup of flic
0edc990c45 s390x/flic: simplify flic initialization
1b3a2452b9 s390x/tcg: deliver multiple interrupts in a row
6c1d71e1d7 Fix configure for s390 qemu on alpine and other busybox environments

=== OUTPUT BEGIN ===
Checking PATCH 1/29: Fix configure for s390 qemu on alpine and other busybox 
environments...
Checking PATCH 2/29: s390x/tcg: deliver multiple interrupts in a row...
Checking PATCH 3/29: s390x/flic: simplify flic initialization...
Checking PATCH 4/29: s390x/tcg: simplify lookup of flic...
Checking PATCH 5/29: s390x/tcg: simplify machine check handling...
Checking PATCH 6/29: s390x/flic: factor out injection of floating interrupts...
Checking PATCH 7/29: s390x/flic: no need to call s390_io_interrupt() from 
flic...
Checking PATCH 8/29: s390x/tcg: tolerate wrong wakeups due to floating 
interrupts...
Checking PATCH 9/29: s390x/flic: make floating interrupts on TCG actually 
floating...
Checking PATCH 10/29: s390x/tcg: implement TEST PENDING INTERRUPTION...
Checking PATCH 11/29: s390x/flic: implement qemu_s390_clear_io_flic()...
Checking PATCH 12/29: s390x/flic: optimize CPU wakeup for TCG...
Checking PATCH 13/29: s390x: fix size + content of STSI blocks...
Checking PATCH 14/29: s390x/tcg: STSI overhaul...
Checking PATCH 15/29: s390x/tcg: remove SMP warning...
Checking PATCH 16/29: configure: s390x supports mttcg now...
Checking PATCH 17/29: s390x/tcg: cache the qemu flic in a central function...
Checking PATCH 18/29: s390x/kvm: cache the kvm flic in a central function...
Checking PATCH 19/29: s390x/flic: cache the common flic class in a central 
function...
Checking PATCH 20/29: s390x/sclp: fix event mask handling...
Checking PATCH 21/29: s390x/tcg: wire up pci instructions...
Checking PATCH 22/29: s390x/cpumodel: allow zpci features in qemu model...
Checking PATCH 23/29: s390x/cpumodel: model PTFF subfunctions for 
Multiple-epoch facility...
ERROR: line over 90 characters
#29: FILE: target/s390x/cpu_features.c:159:
+    FEAT_INIT("ptff-qsie", S390_FEAT_TYPE_PTFF, 10, "PTFF Query Steering 
Information Extended"),

ERROR: line over 90 characters
#30: FILE: target/s390x/cpu_features.c:160:
+    FEAT_INIT("ptff-qtoue", S390_FEAT_TYPE_PTFF, 13, "PTFF Query TOD Offset 
User Extended"),

WARNING: line over 80 characters
#33: FILE: target/s390x/cpu_features.c:163:
+    FEAT_INIT("ptff-stoe", S390_FEAT_TYPE_PTFF, 73, "PTFF Set TOD Offset 
Extended"),

WARNING: line over 80 characters
#34: FILE: target/s390x/cpu_features.c:164:
+    FEAT_INIT("ptff-stoue", S390_FEAT_TYPE_PTFF, 77, "PTFF Set TOD Offset User 
Extended"),

ERROR: line over 90 characters
#42: FILE: target/s390x/cpu_features.c:452:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements 
introduced with Multiple-epoch facility"),

ERROR: Macros with complex values should be enclosed in parenthesis
#71: FILE: target/s390x/gen-features.c:62:
+#define S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF \
+    S390_FEAT_PTFF_QSIE, \
+    S390_FEAT_PTFF_QTOUE, \
+    S390_FEAT_PTFF_STOE, \
+    S390_FEAT_PTFF_STOUE

total: 4 errors, 2 warnings, 80 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 24/29: s390x/pci: fixup the code walking IOMMU tables...
Checking PATCH 25/29: s390x/pci: fixup global refresh...
Checking PATCH 26/29: s390x/pci: use the right pal and pba in reg_ioat()...
Checking PATCH 27/29: MAINTAINERS: add myself as overall s390x maintainer...
Checking PATCH 28/29: MAINTAINERS: reorganize s390-ccw bios maintainership...
Checking PATCH 29/29: MAINTAINERS: add David as additional tcg/s390 
maintainer...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

Reply via email to