On 02/13/2018 04:06 AM, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>

The boot block used in the migration test is currently only
shipped as a hex (with the source in the git commit message of ea0c6d62),
change this to actually include the source.

A script is added to rebuild the header but the expectation is that
the generated hex is shipped as well as the .s, so that
there's no requirement to have just the right assembler etc.

Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
  tests/migration-test.c                   | 52 ++----------------
  tests/migration/rebuild-x86-bootblock.sh | 34 ++++++++++++
  tests/migration/x86-a-b-bootblock.h      | 51 ++++++++++++++++++
  tests/migration/x86-a-b-bootblock.s      | 92 ++++++++++++++++++++++++++++++++
  4 files changed, 181 insertions(+), 48 deletions(-)
  create mode 100755 tests/migration/rebuild-x86-bootblock.sh
  create mode 100644 tests/migration/x86-a-b-bootblock.h
  create mode 100644 tests/migration/x86-a-b-bootblock.s

Looks like you addressed all my v3 findings, so
Reviewed-by: Eric Blake <ebl...@redhat.com>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to