Since v3: - use assert() in sd_state_name() and sd_response_name() (Alistair review) - added sdmmc-internal.h & sdmmc-common.c to reuse helpers with hw/sd/core.c
Since v2: - split again in 2... this part is cleanup/tracing - add more tracepoints - move some code reusable by sdbus in sdmmc-internal.h Since v1: - rewrote mostly all patches to keep it simpler. $ git backport-diff 001/11:[----] [--] 'sdcard: reorder SDState struct members' 002/11:[0003] [FC] 'sdcard: replace DPRINTF() by trace events' 003/11:[0001] [FC] 'sdcard: add a trace event for command responses' 004/11:[0007] [FC] 'sdcard: replace fprintf() by qemu_hexdump()' 005/11:[----] [--] 'sdcard: add more trace events' 006/11:[----] [--] 'sdcard: do not trace CMD55 when expecting ACMD' 007/11:[0014] [FC] 'sdcard: define SDMMC_CMD_MAX instead of using the magic '64'' 008/11:[0020] [FC] 'sdcard: display command name when tracing CMD/ACMD' 009/11:[----] [--] 'sdcard: display protocol used when tracing' 010/11:[----] [-C] 'sdcard: use G_BYTE from cutils' 011/11:[----] [-C] 'sdcard: use the registerfields API to access the OCR register' Philippe Mathieu-Daudé (11): sdcard: reorder SDState struct members sdcard: replace DPRINTF() by trace events sdcard: add a trace event for command responses sdcard: replace fprintf() by qemu_hexdump() sdcard: add more trace events sdcard: do not trace CMD55 when expecting ACMD sdcard: define SDMMC_CMD_MAX instead of using the magic '64' sdcard: display command name when tracing CMD/ACMD sdcard: display protocol used when tracing sdcard: use G_BYTE from cutils sdcard: use the registerfields API to access the OCR register hw/sd/sdmmc-internal.h | 18 +++++ include/hw/sd/sd.h | 1 - hw/sd/sd.c | 184 ++++++++++++++++++++++++++++++++++--------------- hw/sd/sdmmc-common.c | 72 +++++++++++++++++++ hw/sd/Makefile.objs | 2 +- hw/sd/trace-events | 20 ++++++ 6 files changed, 241 insertions(+), 56 deletions(-) create mode 100644 hw/sd/sdmmc-internal.h create mode 100644 hw/sd/sdmmc-common.c -- 2.16.1
