On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
1. NBD_REP_ERR_INVALID is not only about length, so, make message more

2. hex format is not very good: it's hard to read something like
    "option a (set meta context)", so switch to dec.

It would be okay as option 0xa; I also want to be sure we match the output in server traces with the output in client traces; for example, I found:

nbd/server.c- error_setg(errp, "Unsupported option 0x%" PRIx32 " (%s)",
nbd/server.c:                           option, nbd_opt_lookup(option));

So we want consistency through all the call sites, before this patch is ready to go, although I agree we need it.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to