On 02/19/2018 03:15 AM, Thomas Huth wrote:
It looks strange that net_init_client() and net_init_netdev() both
take an "Error **errp" parameter, but then do the error reporting
with "error_report_err(local_err)" on their own. Let's move the
error reporting to the calling site instead to simplify this code
a little bit.

Signed-off-by: Thomas Huth <th...@redhat.com>
---
  include/net/net.h |  2 +-
  net/net.c         | 29 +++++------------------------
  vl.c              |  3 ++-
  3 files changed, 8 insertions(+), 26 deletions(-)


Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to