Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180218144021.11641-1-vinc...@bernat.im
Subject: [Qemu-devel] [RFC, PATCH, v1] hw/audio/opl2lpt: add support for OPL2LPT

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c83e23c953 hw/audio/opl2lpt: add support for OPL2LPT

=== OUTPUT BEGIN ===
Checking PATCH 1/1: hw/audio/opl2lpt: add support for OPL2LPT...
ERROR: spaces required around that '/' (ctx:VxV)
#154: FILE: hw/audio/opl2lpt.c:91:
+               diff/1000, nport, v);
                    ^

ERROR: spaces required around that '/' (ctx:VxV)
#167: FILE: hw/audio/opl2lpt.c:104:
+               diff/1000, nport, v);
                    ^

ERROR: initializer for struct MemoryRegionPortio should normally be const
#206: FILE: hw/audio/opl2lpt.c:143:
+static MemoryRegionPortio opl2lpt_portio_list[] = {

ERROR: space prohibited before that '++' (ctx:WxB)
#216: FILE: hw/audio/opl2lpt.c:153:
+    for (int i = 0; i < 256; i ++) {
                                ^

WARNING: line over 80 characters
#235: FILE: hw/audio/opl2lpt.c:172:
+    portio_list_init(&s->port_list, OBJECT(s), opl2lpt_portio_list, s, 
"opl2lpt");

total: 4 errors, 1 warnings, 231 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

Reply via email to