Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > Overriding the backing image should result in a json:{} pseudo-filename. > Then, you can no longer use the commit block job with filename > parameters. Therefore, do not explicitly add the base and override the > middle image in iotest 191, since we do not need to anyway. This will > allow us to continue to use the middle image's filename to identify it. > > In the long run, we want block-commit to accept node names for base and > top (just like block-stream does). > > Signed-off-by: Max Reitz <mre...@redhat.com>
Is this actually needed once the FIXME in patch 3 is addressed and only significant fields are considered, or can we revert the patch at the end of the series? Once we implement a node-named based blockdev-commit, we'll want to test both versions here, so it would be good to be able to set a node-name and still be able to use the filename for the older interface. Kevin