On 02/23/2018 08:41 AM, Peter Maydell wrote: > On 17 February 2018 at 18:22, Richard Henderson > <richard.hender...@linaro.org> wrote: >> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> >> --- >> target/arm/helper-sve.h | 18 ++++ >> target/arm/sve_helper.c | 247 >> +++++++++++++++++++++++++++++++++++++++++++++ >> target/arm/translate-sve.c | 96 ++++++++++++++++++ >> target/arm/sve.decode | 19 ++++ >> 4 files changed, 380 insertions(+) > > >> + b = g & n; /* guard true, pred true*/ > > missing space before */ > >> +/* Given a computation function, compute a merging BRK. */ >> +static void compute_brk_m(uint64_t *d, uint64_t *n, uint64_t *g, >> + intptr_t oprsz, bool after) > > Comment says "given a computation function" but the prototype > doesn't take a function as parameter ?
Whoops, old comment. FWIW, it did at one point. r~
