On 02/26/2018 11:35 AM, Cornelia Huck wrote: > On Mon, 26 Feb 2018 11:28:26 +0100 > David Hildenbrand <da...@redhat.com> wrote: > >> On 26.02.2018 11:19, Cornelia Huck wrote: >>> On Fri, 23 Feb 2018 18:36:57 +0100 >>> David Hildenbrand <da...@redhat.com> wrote: >>> >>>> Right now it is possible to crash QEMU for s390x by providing e.g. >>>> -numa node,nodeid=0,cpus=0-1 >>>> >>>> Problem is, that numa.c uses mc->cpu_index_to_instance_props as an >>>> indicator whether NUMA is supported by a machine type. We don't >>>> implement NUMA on s390x (and that concept also doesn't really exist). >>>> We need mc->cpu_index_to_instance_props for query-cpus. >>> >>> Is existence of cpu_index_to_instance_probs the correct indicator for >>> numa, then? >>> >>> OTOH, your patch is straightforward... >> >> Maybe it is get_default_cpu_node_id as Christian discovered? > > Yes, that seems like a better candidate for checking.
Agreed. As everybody else calls possible_cpu_arch_ids in cpu_index_to_props I am asking myself if we should do that as well anyway?