On Thu, Mar 01, 2018 at 06:22:40PM +0100, Paolo Bonzini wrote: > On 01/03/2018 09:44, Peter Xu wrote: > > +/** > > + * qio_channel_tls_handshake_full: > > + * @ioc: the TLS channel object > > + * @func: the callback to invoke when completed > > + * @opaque: opaque data to pass to @func > > + * @destroy: optional callback to free @opaque > > + * @context: the context that TLS handshake will run with > > + * > > + * Similar to qio_channel_tls_handshake(), but allows the task to be > > + * run on a specific context. > > + */ > > +void qio_channel_tls_handshake_full(QIOChannelTLS *ioc, > > + QIOTaskFunc func, > > + gpointer opaque, > > + GDestroyNotify destroy, > > + GMainContext *context); > > + > > You're not consistent in introducing "_full" functions. I would > add the argument directly to the qio_channel_tls_handshake() function.
Will take your advise. Thanks, -- Peter Xu
