On 03/01/18 15:59, Marc-André Lureau wrote: > Hi > > On Fri, Feb 23, 2018 at 6:31 PM, Laszlo Ersek <ler...@redhat.com> wrote:
>> (6) Now, I realize Tcg2Pei *apparently* depends on >> gEfiPeiReadOnlyVariable2PpiGuid (i.e., read-only variable access in the >> PEI phase) as well. That's a bug in the INF file (the [depex] section). >> If you grep the Tcg2Pei module source for the GUID, the [depex] section >> is the only hit. Can you please submit a separate patch that removes it >> from the depex? > > I don't get how you came to that conclusion, both > SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c and > SecurityPkg/Tcg/Tcg2Config/TpmDetection.c match. Apparently, the > variable is used in s3 mode, in DetectTpmDevice(). In my point (6) above, I was talking about Tcg2Pei, not Tcg2ConfigPei. If you grep "SecurityPkg/Tcg/Tcg2Pei" for "gEfiPeiReadOnlyVariable2PpiGuid", the only hit is the depex section in the INF file. I think that's a bug in "SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf", and the PPI GUID should removed from there, as a separate patch. >>> --- >>> OvmfPkg/OvmfPkgX64.dsc | 20 ++++++++++++++++++++ >>> OvmfPkg/OvmfPkgX64.fdf | 3 +++ >>> 2 files changed, 23 insertions(+) >> >> Is there any particular reason to exclude the Ia32 and Ia32X64 builds? >> >> If not, then please modify all three sets of dsc/fdf files identically. > > I'd rather keep this as a TODO item for now, since we are not close to > a final version, and it's annoying to have to fix each files etc.. OK. Thanks! Laszlo
