On 03/02/2018 02:02 PM, Dr. David Alan Gilbert wrote:
* miny...@acm.org (miny...@acm.org) wrote:
I apologize for the resend, I left the list off the previous post.

This is unchanged since the previous post, two weeks ago.  I received
no comments, so I guess it's ok.  It's fairly broken now, so I would
like this fixed.
Sorry, I'll look at it on Monday; I was out last week and hadn't got
around to this set.

Thanks a bunch.  I have some doubt about how I handled the backwards
compatibility in the KCS code.  It works, but I'm not sure it's right.



Changes from v1:
   * Validate the data values in pre_load functions.
   * For KCS, instead of an old function, create a separate vmstate
     structure for the new version.  The name on the old vmstate
     structure wasn't specific enough, so a new name was needed,
     The old structure is set up to never be sent, but it can be

The following changes since commit 427cbc7e4136a061628cb4315cc8182ea36d772f:

   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging 
(2018-03-01 18:46:41 +0000)

are available in the git repository at:

   https://github.com/cminyard/qemu.git tags/ipmi-vmstate-fixes

for you to fetch changes up to 90797371d9a3138657e7b1f7ab4425eb67d6fd0a:

   ipmi: Use proper struct reference for BT vmstate (2018-03-02 07:48:39 -0600)

Fix the IPMI vmstate code to work correctly in all cases.  Heavily
tested under load.

Corey Minyard (2):
       ipmi: Use proper struct reference for KCS vmstate
       ipmi: Use proper struct reference for BT vmstate

  hw/ipmi/isa_ipmi_bt.c  | 61 ++++++++++++++++++++++++++++++---------
  hw/ipmi/isa_ipmi_kcs.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++++--
  2 files changed, 123 insertions(+), 15 deletions(-)

Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Reply via email to