Richard W.M. Jones <rjo...@redhat.com> writes: > The attached patch is also needed to avoid crashes during various > math-heavy test suites. > > Rich. > > -- <snip> > From: Stef O'Rear <sore...@gmail.com> > Date: Sat, 3 Mar 2018 03:46:00 -0800 > Subject: [PATCH] softfloat: fix crash on int conversion of SNaN > > Signed-off-by: Stef O'Rear <sore...@gmail.com> > --- > fpu/softfloat.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fpu/softfloat.c b/fpu/softfloat.c > index e7fb0d357a..1da1db377e 100644 > --- a/fpu/softfloat.c > +++ b/fpu/softfloat.c > @@ -1342,6 +1342,8 @@ static int64_t round_to_int_and_pack(FloatParts in, int > rmode, > switch (p.cls) { > case float_class_snan: > case float_class_qnan: > + case float_class_dnan: > + case float_class_msnan: > return max; > case float_class_inf: > return p.sign ? min : max; > @@ -1430,6 +1432,8 @@ static uint64_t round_to_uint_and_pack(FloatParts in, > int rmode, uint64_t max, > switch (p.cls) { > case float_class_snan: > case float_class_qnan: > + case float_class_dnan: > + case float_class_msnan: > s->float_exception_flags = orig_flags | float_flag_invalid; > return max; > case float_class_inf:
Obviously I wasn't exercising the NaN exit paths enough and we added the return_nan() common code fairly late in the series. Reviewed-by: Alex Bennée <alex.ben...@linaro.org> -- Alex Bennée