On 03/05/2018 03:57 PM, Daniel P. Berrangé wrote: > On Mon, Mar 05, 2018 at 08:27:04AM -0300, Philippe Mathieu-Daudé wrote: >> These files were including "qemu/cutils.h" to use the byte-based size >> definitions, now available in "qemu/cunits.h". > > I know I'm "complaining" about bike-shed colour here.... > > Feels like just calling it units.h is sufficient - all our .h code is > C code so don't need reminding of it by filename, particularly since > we're avoiding system header clash by using the qemu/ prefix on #includes.
I like your suggestion :) > >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > Regardless of whether you rename it or not though, > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Thanks! > > > Regards, > Daniel >
