On 6 March 2018 at 13:38, Daniel P. Berrangé <berra...@redhat.com> wrote: > On Tue, Mar 06, 2018 at 01:33:42PM +0000, Peter Maydell wrote: >> If the type isn't "hwaddr" then HWADDR_PRIx is the wrong >> format string macro -- those should change to PRIx64. > > Eeek, that HWADDR_PRIx macro is used throughout this file, sometimes > even with uint32_t as the arg !
Mmm, it's used where PRIx64 should be, but I think only for uint64_t arguments; I can't see a uint32_t one. hw/ide/trace-events also has a couple of HWADDR_PRIx uses. thanks -- PMM
