On 6 March 2018 at 17:47, Thomas Huth <th...@redhat.com> wrote: > Does the device need to be hot-pluggable or even user_creatable at all? > It seems like it is also using serial_hds directly, so that is a good > indication that it is *not* user creatable. So maybe the easiest fix is > to simply set > > dc->user_creatable = false; > > in macio_class_init() ?
Yes. As Thomas says, if your device is using serial_hds directly it is not user creatable. The ideal design here is that the device does not touch serial_hds at all, but instead has qdev properties for char devices, which the board model code wires up based on serial_hds. (In this case you could make them just be alias properties into the escc object that the macio device creates.) Either way I don't think there's any reason for the device to be user-creatable. thanks -- PMM