On Wed, Mar 07, 2018 at 04:06:53PM +0100, Paolo Bonzini wrote: > On 07/03/2018 13:40, Daniel P. Berrangé wrote: > > On Wed, Mar 07, 2018 at 12:36:50PM +0000, Daniel P. Berrangé wrote: > >> On Tue, Mar 06, 2018 at 01:33:20PM +0800, Peter Xu wrote: > >>> TLS handshake may create background GSource tasks, while we won't know > >>> the correct GMainContext until the whole chardev (including frontend) > >>> inited. Let's postpone the initial TLS handshake until machine done. > >>> > >>> For dynamically created tcp chardev, we don't postpone that by checking > >>> the init_machine_done variable. > >> > >> Not sure I see the need for this one - we've already postponed the > >> acceptance of a client in the patch 7. > > > > Opps, meant to remove this comment, in favour of the later comment - ignore > > this bit. > > Since time is ticking for soft freeze, I'll queue the series without > this patch.
Thanks Paolo. Note that Dan's pull is still not merged yet, and this series will need that one. I'll try to see whether I can prepare a good version for the last TLS patch before you start to test your next pull request. -- Peter Xu