On 8 March 2018 at 07:09, Thomas Huth <th...@redhat.com> wrote:
> It's the third case. The "generic" code was just removed with commit
> 1454509726719e0933 since it was considered as a big hack. The generic
> code should not have to guess to which SCSI adapter a SCSI drive should
> be attached to. That's the job of the board init code, and this is what
> this patch is doing now for the 40p machine.
> Other boards like the "pseries" machine were doing this since a long
> time already (see the spapr_vscsi_create() function in
> hw/scsi/spapr_vscsi.c for example).
>> You just fixed 40p and MIPS Jazz machines, but sparc/SS-10 (and other)
>> also have the same problem...
> I also posted a patch for the Sparc machines, you can find it here:
> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg01830.html

Are we sure this is the entire list of machines that use this?

Can we in general try to avoid removing generic code features
until we've checked and fixed everything that relies on them? x86 pc
is not the only system we support...

-- PMM

Reply via email to