On 03/06/2018 10:00 AM, Stefan Hajnoczi wrote:
On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote:
v2:
01: add block_latency_histogram_clear()
02: fix spelling (sorry =()
some rewordings
remove histogram if latency parameter unspecified
Vladimir Sementsov-Ogievskiy (2):
block/accounting: introduce latency histogram
qapi: add block latency histogram interface
qapi/block-core.json | 73 +++++++++++++++++++++++++++++++++-
include/block/accounting.h | 9 +++++
block/accounting.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++
block/qapi.c | 31 +++++++++++++++
blockdev.c | 19 +++++++++
5 files changed, 228 insertions(+), 1 deletion(-)
The feature looks good. I posted documentation and code readability
suggestions.
I also think it makes sense; if a v3 hits the list in time, I will
probably include it in my last QAPI pull before softfreeze.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
