On 8 March 2018 at 19:53, Michael Clark <m...@sifive.com> wrote: > I re-iterate Palmer's apology. > > I shouldn't be polling git.qemu.org/qemu.git and answering emails near to > 3am in the morning after 4 months of working on trying to get the RISC-V > port in shape to go upstream. > > It appears it is completely my mistake and I had tagged early deltas on top > of v8.2 instead of the tip of v8.2. > > I've force pushed the 'riscv-qemu-upstream-v8.2' so only the mailing list > will hold the history of my mistake.
Thank you for the apology. On my side, I regret not starting this email thread by just asking if you'd pushed the wrong tag by mistake, since in retrospect that was certainly the most likely situation. I've now merged and tested the revised tag, and pushed it upstream. NB: there was a test failure on OpenBSD host: TEST: tests/qom-test... (pid=64016) /riscv32/qom/spike_v1.9.1: ** ERROR:/home/qemu/tests/qom-test.c:64:test_properties: assertion failed: (qdict_haskey(response, "return")) FAIL but this seems to have been intermittent -- it was only on that one host, and I reran the test suite there and it passed fine the second time. So it may be nothing to do with your code; we'll see if it comes up again. I also had a look at running the port under valgrind, which shows what looks like a bug in riscv_isa_string(): $ valgrind ./build/all/riscv32-softmmu/qemu-system-riscv32 [...] ==24805== Invalid read of size 1 ==24805== at 0x4C30F74: strlen (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==24805== by 0x26518E: riscv_isa_string (cpu.c:399) ==24805== by 0x25C15D: create_fdt (spike.c:125) ==24805== by 0x25C15D: spike_v1_10_0_board_init (spike.c:199) ==24805== by 0x2CCE1A: machine_run_board_init (machine.c:807) ==24805== by 0x1BFF28: main (vl.c:4597) ==24805== Address 0x3055be55 is 0 bytes after a block of size 5 alloc'd ==24805== at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==24805== by 0x70C8770: g_malloc0 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2) ==24805== by 0x26512E: riscv_isa_string (cpu.c:395) ==24805== by 0x25C15D: create_fdt (spike.c:125) ==24805== by 0x25C15D: spike_v1_10_0_board_init (spike.c:199) ==24805== by 0x2CCE1A: machine_run_board_init (machine.c:807) ==24805== by 0x1BFF28: main (vl.c:4597) I haven't looked too hard at the code, but I suspect you're miscalculating the length of the string and/or not writing the trailing NUL to the string. I recommend you have a look at that, and perhaps try running some other tests under valgrind. thanks -- PMM
