On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote:
This test case adds an NBD server export and then invokes
blockdev-snapshot-sync, which changes the BlockDriverState node that the
Do we want to test 'blockdev-snapshot' instead (or in addition), given
the subthread discussion about blockdev-snapshot-sync being the older
non-preferred form?
NBD server's BlockBackend points to. This is an interesting scenario to
test and exercises the code path fixed by the previous commit.
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
---
tests/qemu-iotests/208 | 55 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/208.out | 9 ++++++++
tests/qemu-iotests/group | 1 +
3 files changed, 65 insertions(+)
create mode 100755 tests/qemu-iotests/208
create mode 100644 tests/qemu-iotests/208.out
Switching the order of the two patches in this series makes it obvious
that this patch does tickle the code path in question, so you definitely
get:
Tested-by: Eric Blake <ebl...@redhat.com>
And unless answering the question about blockdev-snapshot causes you to
change things for more/different QMP commands, I'm also fine with:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
