09.03.2018 18:40, Eric Blake wrote:
On 03/09/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote:
v4:

Move block_latency_histogram_set from block/accounting.c to
blockdev.c, as it uses qapi type uint64List and this fact breaks
build.

Was the cross file motion necessary, or could you just fix the #includes according to the recent qapi header refactoring?


Looks like it's not as simple..

/tmp/qemu-test/src/include/block/accounting.h:30:10: fatal error: qapi-types.h: 
No such file or directory
 #include "qapi-types.h


what to do now? Looks like qapi-types are not generated for some builds. So, 
this version (v4) should take place.

--
Best regards,
Vladimir


Reply via email to