On 03/09/2018 11:27 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf <kw...@redhat.com>
---
  tests/qemu-iotests/208       | 211 +++++++++++++++++++++++++++++++++++++++++++
  tests/qemu-iotests/208.out   | 136 ++++++++++++++++++++++++++++
  tests/qemu-iotests/common.rc |   2 +-
  tests/qemu-iotests/group     |   1 +
  4 files changed, 349 insertions(+), 1 deletion(-)
  create mode 100755 tests/qemu-iotests/208
  create mode 100644 tests/qemu-iotests/208.out

I've seen another patch using 208 - someone gets to renumber ;)

+# creator
+owner=kw...@redhat.com
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+status=1       # failure is the default!

Whatever happened to Jeff's efforts to reduce pointless boilerplate?


+function do_run_qemu()
+{
+    echo Testing: "$@"
+    $QEMU -nographic -qmp stdio -serial none "$@"

Is -nodefaults better than -serial none?

At any rate, my comments are trivial, whether or not you do something about them, so

Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to