On Fri, 9 Mar 2018, Eduardo Habkost wrote: > On Fri, Mar 09, 2018 at 12:07:21PM +0000, Ian Jackson wrote: > > Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict > > until just before os_setup_post"): > > > Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to > > > xen_restrict until just before os_setup_post"): > > > > I don't think we should have accelerator-specific code in main(), > > > > if we already have accelerator classes that can abstract that > > > > out. I suggest adding a AccelClass;:setup_post() method that can > > > > be called here. > > > > > > I think I can do that. > > > > How about this ? > > > > From 61f11221afaa29e10021599420238e03836ba413 Mon Sep 17 00:00:00 2001 > > From: Ian Jackson <ian.jack...@eu.citrix.com> > > Date: Fri, 9 Mar 2018 12:02:50 +0000 > > Subject: [PATCH v6.2 12/11] AccelClass: Introduce accel_setup_post > > > > This is called just before os_setup_post. Currently none of the > > accelerators provide this hook, but the Xen one is going to provide > > one in a moment. > > > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > > Looks good to me. > > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > > That said, I don't think this should block the inclusion of the > previous patch in 2.12, if the Xen maintainers were already going > to merge it.
Ian, The Xen side is almost entirely reviewed and should be OK, but you need reviewed-bys on some non-Xen specific patches: #7 #8 #11. Cheers, Stefano