On Sat, Mar 10, 2018 at 08:59:38PM -0600, Eric Blake wrote:
> On 03/09/2018 02:59 AM, Peter Xu wrote:
> > Based-on: <20180306053320.15401-1-pet...@redhat.com>
> > The series is based on the following series:
> > [PATCH v2 0/9] chardev: qio related non-default context support
> > (actually patch 9 is based on version 2.1, Dan's version)
> > This version only contains some trivial changes, most of the work is
> > posted separately in either the QIO or CHARDEV series.
> > Four days until soft freeze. Hmm...
> > Please review. Thanks,
> > v8:
> > - fix up doc patch as suggested [Eric]
> > - rename functions in form of X_get_Y() or X_bh() [Stefan]
> > - English fixes [Stefan]
> > - make sure to kick iothread after suspend count update [Stefan]
> > - remove the hack to remove fd in monitor_init(), since now we have
> > the QIO/CHARDEV series to solve the root problem.
> Still a lot that I had to clean up (in part due to conflicts with other
> pending patches that also touch qapi), but given the utility of this
> feature, and the impending deadline for freeze, I've gone ahead and done the
> cleanup work. Your patches are now stages on my QAPI tree.
> git://repo.or.cz/qemu/ericb.git qapi
> Note that I had some ideas for followup patches (mainly strengthening the
> testsuite, which is typically safe early on in freeze because it is not
> introducing features but strengthening the quality of the release).
I really appreciate very much on your work and time on the series.
I've noted down all the review comments, including the test
enhancements (which I'll do in a proper way soon). I'll avoid
replying to every review comments since all of them are sane.
Note that this series will depend on the chardev fixes ( above) in
Paolo's tree. They'll possibly not be needed for compilation, but
might be needed for further tests. Hope that won't be a big problem.