> -----Original Messages----- > From: "Peter Maydell" <peter.mayd...@linaro.org> > Sent Time: 2018-03-12 19:40:22 (Monday) > To: "Su Hang" <suhan...@mails.ucas.ac.cn> > Cc: "thomas huth" <th...@redhat.com>, "QEMU Developers" > <qemu-devel@nongnu.org> > Subject: Re: [Qemu-devel] BiteSizedTasks: API conversion > > On 12 March 2018 at 11:24, Su Hang <suhan...@mails.ucas.ac.cn> wrote:
> list. Any individual conversion of a callsite is probably small > enough to be bite-sized, but you shouldn't consider "change > everywhere" to be a single small task.) > and I think that would be the best thing: > (1) have address_space_write_rom() which takes the extra > MemTxAttrs argument and returns the MemTxResult, and > make cpu_physical_memory_write_rom() just be a trivial > wrapper around it > (2) then change the callers to use address_space_write_rom() > (3) remove the cpu_physical_memory_write_rom() wrapper > > Step 2 is the harder part, because really it requires looking at > the call sites to see what they should do if the memory access > fails. > > thanks > -- PMM Thanks for your suggestion, I will work on it, step by step. Su Hang
