On 19 March 2018 at 14:40, Igor Mammedov <imamm...@redhat.com> wrote: > On Thu, 15 Mar 2018 17:13:03 +0000 > Peter Maydell <peter.mayd...@linaro.org> wrote: >> Igor, can you help with this question? For a board that always >> has one CPU type (because the real hardware only ever has >> one SoC, and that SoC QOM object hard codes the CPU type) >> does it still need to set the mc->default_cpu_type field in >> its MachineClass, or does that become pointless ? > > Since board ignores whatever were specified on '-cpu' and > there aren't any checks in board code for current_machine->cpu_type, > removing mc->default_cpu_type won't really affect anything. > > With current code in vl.c and with default_cpu_type set, user will > get error if he specified non existing cpu_model with -cpu. > If default_cpu_type were NULL, -cpu is completely ignored. > > But once http://patchwork.ozlabs.org/patch/870297/ is applied > it will error out the same way as if default_cpu_type were > set since vl.c won't rely on it anymore for parsing cpu_model. > > So in short it's ok to remove mc->default_cpu_type here.
Thanks for the explanation. I think what I'll do is put these in as-is, and then have a followup patch that cleans up the default_cpu_types from raspi.c once that patch 870297 is in. -- PMM
