* Eric Blake (ebl...@redhat.com) wrote: > On 03/21/2018 07:37 AM, Max Reitz wrote: > > On 2018-03-12 19:36, Eric Blake wrote: > > > From: Peter Xu <pet...@redhat.com> > > > > > > Start to use dedicate IO thread for QMP monitors that are not using > > > MUXed chardev. > > > > > > Reviewed-by: Fam Zheng <f...@redhat.com> > > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > > Message-Id: <20180309090006.10018-21-pet...@redhat.com> > > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > > --- > > > monitor.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > It seems the iotests aren't quite ready for this change (breakage in > > 040, 041, 051, 060, 085, 087, 093, 095, 109, 124, 127, 132, 136, 144, > > 148, 152, 182, 183, 185, 186; and 030 hangs). > > Serves me right for not testing iotests on my qapi tree as rigoursly as I do > on my NBD tree. Fixing this during freeze is acceptable, although I'd like > it if Peter Xu can take a look instead of just me. > > (And still a bummer that iotests aren't being run by 'make check' or CLI to > have caught it earlier?)
I'm guessing from those that 030 is the easiest to try and debug because it hangs and you get a nice backtrace. The others are a bit mysterious (I think it's 042 which just has an f in one place in the output rather than a .) Dave > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
