On Fri, 23 Mar 2018 18:28:37 -0300 Eduardo Habkost <ehabk...@redhat.com> wrote:
> On Mon, Mar 12, 2018 at 02:11:11PM +0100, Igor Mammedov wrote: > > New option will be used to allow commands, which are prepared/need > > to run run in preconfig state. Other commands that should be able > > to run in preconfig state, should be ammeded to not expect machine > > in initialized state or deal with it. > > > > For compatibility reasons, commands, that don't use new flag > > 'allowed-in-preconfig' explicitly, are not permited to run in > > preconfig state but allowed in all other states like they used > > to be. > > > > Within this patch allow following commands in preconfig state: > > qmp_capabilities > > query-qmp-schema > > query-commands > > query-status > > cont > > to allow qmp connection, basic introspection and moving to the next > > state. > > > > PS: > > set-numa-node and query-hotpluggable-cpus will be enabled later in > > a separate patch. > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > I didn't review the code yet, but: > > Shouldn't this be applied before patch 3/9, for bisectability? > Otherwise it will be very easy to crash QEMU after applying patch > 3/9. no, it isn't going to work. This patch depends on RUN_STATE_PRECONFIG that is introduced in 3/9. It could be fine to merge into 3/9 during merge, but then history wise it would be difficult to read it later with 2 big and mostly separate changes within one patch. Considering -preconfig if off by default it shouldn't affect bisectability in general so I'd keep current patch order.
