On 03/27/2018 03:21 PM, Eric Blake wrote: > gcc 8 on rawhide is picky enough to complain: > > /home/dummy/qemu/dump.c: In function 'create_header32': > /home/dummy/qemu/dump.c:817:5: error: 'strncpy' output truncated before > terminating nul copying 8 bytes from a string of the same length > [-Werror=stringop-truncation] > strncpy(dh->signature, KDUMP_SIGNATURE, strlen(KDUMP_SIGNATURE)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > But we already have SIG_LEN defined as the right length without needing > to do a strlen(), and memcpy() is better than strncpy() when we know > we do not want a trailing NUL byte. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > dump.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
I'll include this in my qapi+misc pull request for 2.12-rc2 -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature