On 04/10/2018 01:29 PM, Max Filippov wrote: > On Mon, Apr 9, 2018 at 8:20 PM, Richard Henderson > <richard.hender...@linaro.org> wrote: >> On 04/10/2018 12:17 PM, Max Filippov wrote: >>> + uint64_t off = tlow | >>> + ((unsigned long long)thigh << TARGET_LONG_BITS / 2) << >> >> There's a second instance of long long here; needs uint64_t. > > Ehh, will fix. > BTW, why is uint64_t here better than unsigned long long? Just > shorter?
Because it's more explicit about the number of bits we're talking about. r~