On Thu, 12 Apr 2018 19:22:13 +0100 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 12 April 2018 at 17:40, Igor Mammedov <imamm...@redhat.com> wrote: > > reduce code duplication by resusing arm_boot_address_space() > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > --- > > include/hw/arm/arm.h | 2 ++ > > hw/arm/armv7m.c | 10 +--------- > > hw/arm/boot.c | 16 ++++++++-------- > > 3 files changed, 11 insertions(+), 17 deletions(-) > > This minor duplication was deliberate, because hw/arm/armv7m.c > is for M profile cores only, and hw/arm/boot.c is for > A/R profile cores only. I don't think that saving a > single if/else in armv7m.c really justifies blurring > that dividing line. I'll drop patch on respin > thanks > -- PMM
