On Mon, Apr 16, 2018 at 07:28:28PM +0100, Peter Maydell wrote: > On 16 April 2018 at 19:18, Marc-André Lureau > <marcandre.lur...@redhat.com> wrote: > > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > > regression, but was inadvertently broken again in merge commit > > 2d6752d38d8acda. > > > > Fixes: > > https://bugs.launchpad.net/qemu/+bug/1654137 > > > > Cc: qemu-sta...@nongnu.org > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > chardev/char-mux.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/chardev/char-mux.c b/chardev/char-mux.c > > index 1b925c8dec..6055e76293 100644 > > --- a/chardev/char-mux.c > > +++ b/chardev/char-mux.c > > @@ -304,6 +304,7 @@ void mux_set_focus(Chardev *chr, int focus) > > } > > > > d->focus = focus; > > + chr->be = d->backends[focus]; > > mux_chr_send_event(d, d->focus, CHR_EVENT_MUX_IN); > > } > > > > -- > > 2.17.0.rc1.36.gcedb63ea2f > > Opinions welcome on whether this is a regression fix worth > putting into rc4.
It is a regression, but a long standing one - we've been broken for quite a while since 2.9.0 or even before. If we're doing an rc4 anyway I'd suggest including it, but not the end of the world if it has to go in via -stable given how long we've been broken for. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|