> > > > Hello, > > > > This is good re-factoring and needed for 'virtio-pmem' as well to > > reserve memory region in system address space. > > > > I have tested this code with virtio-pmem and its working fine. Thank you > > for the work. > > > > I just have a small suggestion : when functions like(get_addr(), > > get_plugged_size etc) > > in the interface are not provided by derived class, Qemu crashes. > > > > I think having a contract for must override functions with NULL check and > > error > > at the calling sites would be better? > > I expect that all of these functions are implemented. It's a contract > for devices that are mapped into address space. We might later have > additional functions that might not be required to be provided and will > be checked for NULL. > > So for the current set of functions, I don't think it makes sense to > make them optional.
o.k. that's reasonable. Thanks, Pankaj > > Thanks! > > > > > Thanks, > > Pankaj > > > -- > > Thanks, > > David / dhildenb >
