On 04/24/2018 10:24 AM, Kevin Wolf wrote: > All block job drivers support .set_speed and all of them duplicate the > same code to implement it. Move that code to blockjob.c and remove the > now useless callback. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > ---
> +++ b/include/block/blockjob.h > @@ -29,6 +29,8 @@ > #include "block/block.h" > #include "qemu/ratelimit.h" > > +#define SLICE_TIME 100000000ULL /* ns */ I know this is just code motion; but would it be any more legible as: #define SLICE_TIME (100ULL * 1000 * 1000) /* ns */ to make it easier to see as 100 ms without having to count the 0s? Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
