On Tue, Apr 24, 2018 at 05:01:57PM -0500, Eric Blake wrote: > We have too many driver callback interfaces; simplify the mess > somewhat by merging the flags parameter of .bdrv_co_writev_flags() > into .bdrv_co_writev_flags(). Note that as long as a driver doesn't
Typo - this should be just .bdrv_co_writev > set .supported_write_flags, the flags argument will be 0 and behavior > is identical. Also note that the public function bdrv_co_writev() > still lacks a flags argument; so the driver signature is thus > intentionally slightly different. But that's not the end of the > world, nor the first time that the driver interface differs slightly > from the public interface. > > Ideally, we should be rewriting all of these drivers to use modern > byte-based interfaces. But that's a more invasive patch to write > and audit, compared to the simplification done here. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > > Based-on: <20180424192506.149089-1-ebl...@redhat.com> > ([PATCH v2 0/6] block: byte-based AIO read/write) > > include/block/block_int.h | 2 -- > block/io.c | 13 ++++--------- > block/gluster.c | 4 +++- > block/iscsi.c | 8 ++++---- > block/parallels.c | 4 +++- > block/qcow.c | 6 ++++-- > block/qed.c | 3 ++- > block/replication.c | 4 +++- > block/sheepdog.c | 4 +++- > block/ssh.c | 4 +++- > block/vhdx.c | 4 +++- > 11 files changed, 32 insertions(+), 24 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|