On 18/04/2018 18:35, Eric Blake wrote:
> On 03/02/2018 06:25 PM, Alexey Kardashevskiy wrote:
>> ObjectPropertyInfo is more generic and only missing @description.
>> This adds a description to ObjectPropertyInfo and removes
>> DevicePropertyInfo so the resulting ObjectPropertyInfo can be used
>> elsewhere.
>>
>> Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru>
>> ---
>> Changes:
>> v4:
>> * added (since 2.12) to the new field
>
> And since it missed 2.12,
It is in 2.12:
commit 961c47bb8bacc9ae21c0760fa6e2594156299dd7
Author: Alexey Kardashevskiy <a...@ozlabs.ru>
Date: Fri Mar 2 00:09:39 2018 +1100
qmp: Add qom-list-properties to list QOM object properties
There is already 'device-list-properties' which does most of the job,
however it does not handle everything returned by qom-list-types such
as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE.
It does not handle abstract classes either.
This adds a new qom-list-properties command which prints properties
of a specific class and its instance. It is pretty much a simplified copy
of the device-list-properties handler.
Since it creates an object instance, device properties should appear
in the output as they are copied to QOM properties at the instance_init
hook.
This adds a object_class_property_iter_init() helper to allow class
properties enumeration uses it in the new QMP command to allow properties
listing for abstract classes.
Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru>
Message-Id: <20180301130939.15875-3-...@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
commit 35f63767dc77d85bebff6c6565aceaf74023776a
Author: Alexey Kardashevskiy <a...@ozlabs.ru>
Date: Fri Mar 2 00:09:38 2018 +1100
qmp: Merge ObjectPropertyInfo and DevicePropertyInfo
ObjectPropertyInfo is more generic and only missing @description.
This adds a description to ObjectPropertyInfo and removes
DevicePropertyInfo so the resulting ObjectPropertyInfo can be used
elsewhere.
Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru>
Message-Id: <20180301130939.15875-2-...@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Thanks,
Paolo
>> * removed wrong reindents
>> ---
>> qapi-schema.json | 23 +++++------------------
>> qdev-monitor.c | 6 +++---
>> qmp.c | 14 +++++++-------
>> 3 files changed, 15 insertions(+), 28 deletions(-)
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 0262b9f..5cdf89a 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -1266,10 +1266,12 @@
>> # 3) A link type in the form 'link<subtype>' where subtype is a qdev
>> # device type name. Link properties form the device model graph.
>> #
>> +# @description: if specified, the description of the property (since 2.12).
>
> this should be tweaked to say since 2.13.
>
>
