On Tue, May 08, 2018 at 06:02:55PM +0200, Paolo Bonzini wrote: > On 08/05/2018 17:19, Daniel P. Berrangé wrote: > > Ok, that change looks fine with me assuming it passes your build tests. > > In fact that is what I had done in an earlier version. > > > > Regards, > > Daniel > > Actually there is a use of g_strv_contains in tests/test-qga.c. It is > guarded by GLIB_CHECK_VERSION(2, 44, 0) but the right fix should be to > include the compatibility function instead. > > For now I am dropping this patch.
Ok, I'll have a look at that, and re-post an updated patch later. There are a few other uses of GLIB_CHECK_VERSION to be investigated too I see. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
