On 10 May 2018 at 15:36, Richard Henderson <r...@twiddle.net> wrote: > On 05/10/2018 06:00 AM, Peter Maydell wrote: >> Usually the logging of the CPU state produced by -d cpu is sufficient >> to diagnose problems, but sometimes you want to see the state of >> the floating point registers as well. We don't want to enable that >> by default as it adds a lot of extra data to the log; instead, >> allow it to be optionally enabled via -d fpu. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> I've found this helpful while tracking down fp-emulation related bugs. >> >> include/qemu/log.h | 1 + >> accel/tcg/cpu-exec.c | 9 ++++++--- >> util/log.c | 2 ++ >> 3 files changed, 9 insertions(+), 3 deletions(-) > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > I'll also note that only i386 and arm check this flag; > something to fix for the rest...
Mmm. It would also be nice not to have that TARGET_I386 special case for CPU_DUMP_CCOP -- we should either care about that for everything, or for nothing (my vote would be for not printing it unless user-requested, since it's an internal tcg target detail.) thanks -- PMM
