Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180511203238.22881-1-andrewjamesw...@ymail.com
Subject: [Qemu-devel] [PATCH] Added SIGPWR handler to send ACPI shutdown
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20180509165530.29561-1-mre...@redhat.com ->
patchew/20180509165530.29561-1-mre...@redhat.com
t [tag update] patchew/20180510204148.11687-1-babu.mo...@amd.com ->
patchew/20180510204148.11687-1-babu.mo...@amd.com
* [new tag]
patchew/20180511203238.22881-1-andrewjamesw...@ymail.com ->
patchew/20180511203238.22881-1-andrewjamesw...@ymail.com
Switched to a new branch 'test'
8f78c34ff5 Added SIGPWR handler to send ACPI shutdown
=== OUTPUT BEGIN ===
Checking PATCH 1/1: Added SIGPWR handler to send ACPI shutdown...
ERROR: that open brace { should be on the previous line
#31: FILE: vl.c:1847:
+ if (signal==SIGPWR)
+ {
ERROR: spaces required around that '==' (ctx:VxV)
#31: FILE: vl.c:1847:
+ if (signal==SIGPWR)
^
ERROR: trailing whitespace
#33: FILE: vl.c:1849:
+^I$
ERROR: code indent should never use tabs
#33: FILE: vl.c:1849:
+^I$
ERROR: code indent should never use tabs
#34: FILE: vl.c:1850:
+^Ipowerdown_requested = 1;$
ERROR: code indent should never use tabs
#35: FILE: vl.c:1851:
+ ^Iqemu_notify_event();$
ERROR: that open brace { should be on the previous line
#37: FILE: vl.c:1853:
+ else
+ {
ERROR: else should follow close brace '}'
#37: FILE: vl.c:1853:
+ }
+ else
ERROR: code indent should never use tabs
#39: FILE: vl.c:1855:
+ ^Ishutdown_requested = SHUTDOWN_CAUSE_HOST_SIGNAL;$
ERROR: code indent should never use tabs
#40: FILE: vl.c:1856:
+ ^Iqemu_notify_event();$
total: 10 errors, 0 warnings, 26 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
