On 15.05.2018 17:10, Eric Blake wrote: > On 05/14/2018 02:55 AM, Jason Wang wrote: >> From: Thomas Huth <th...@redhat.com> >> >> It's been marked as deprecated since QEMU v2.9.0, so that should have >> been enough time for everybody to either just drop unnecessary "vlan=0" >> parameters, to switch to the modern -device + -netdev syntax for >> connecting >> guest NICs with host network backends, or to switch to the "hubport" >> netdev >> in case hubs are really wanted instead. >> >> Buglink: https://bugs.launchpad.net/qemu/+bug/658904 >> Signed-off-by: Thomas Huth <th...@redhat.com> >> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> >> Signed-off-by: Jason Wang <jasow...@redhat.com> >> --- > >> @@ -499,10 +497,11 @@ >> # @opts: device type specific properties (legacy) >> # >> # Since: 1.2 >> +# >> +# 'vlan' - removed with 2.12 > > Shouldn't this be 2.13?
Oh man, yes, of course. Stefan already found that while reviewing my patches (v3), but apparently I forgot to update it in the final v4 :-( Sorry for that. > NetClientDriver > 2.12: dropped 'dump' > ... > NetLegacy > 2.13: dropped 'vlan' > > or the way we do it for QKeyCode: > > NetClientDriver > dump: dropped in 2.12 > ... > NetLegacy > vlan: dropped in 2.13 I think I slightly prefer the latter variant. > As this is already in a pull request, and as NetClientDriver also needs > a cleanup, that can be a followup patch. The pull request has already been merged. I'll send a followup patch... Thomas
