On 05/18/2018 08:21 AM, Kevin Wolf wrote:
This adds a minimal query-jobs implementation that shouldn't pose many
design questions. It can later be extended to expose more information,
and especially job-specific information.

Signed-off-by: Kevin Wolf <kw...@redhat.com>
---
  qapi/job.json      | 45 +++++++++++++++++++++++++++++++++++++++++++++
  include/qemu/job.h |  3 +++
  job-qmp.c          | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
  job.c              |  2 +-
  4 files changed, 103 insertions(+), 1 deletion(-)


+##
+# @JobInfo:
+#
+# Information about a job.
+#
+# @id:                  The job identifier

+##
+{ 'struct': 'JobInfo',
+  'data': { 'id': 'str', 'type': 'JobType', 'status': 'JobStatus',
+            'current-progress': 'int', 'total-progress': 'int',
+            '*error': 'str' } }

Is it worth exposing whether a job is auto-finalize and auto-complete? Goes back to the issue of whether clients of the new job API would ever want/need to rely on the auto- features; while clients of the old blockjob API that get the auto- features by default will never be calling the new query-jobs command.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to