Hi Cornelia, On 05/29/2018 08:40 AM, Cornelia Huck wrote: > On Mon, 28 May 2018 20:27:07 -0300 > Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > >> Code change produced with: >> $ git grep '#include "exec/exec-all.h"' | \ >> cut -d: -f-1 | \ >> xargs egrep -L >> "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)" >> | \ > > Hm, does this expression catch all files that need to include > exec-all.h? The resulting patch seems fine, though.
No, not all :/ I started with "(cpu_loop_|tlb_|tb_)" then kept brutebuilding until no more errors appear. In 2 more steps I added "cpu_address_space_init|" then "|GETPC|singlestep|TranslationBlock". Quick and dirty enough for my goal than trying to build a regex to explode function/struct names from headers. This is a clever way to do it for long term command reuse taken from commit messages... >> xargs sed -i.bak '/#include "exec\/exec-all.h"/d' >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
