On 30.05.2018 16:27, Paolo Bonzini wrote: > On 30/05/2018 16:08, David Hildenbrand wrote: >>>> if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) || >>>> + object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE) || >>> you probably could drop TYPE_PC_DIMM above, it's redundant since DIMM >>> can be cast to TYPE_MEMORY_DEVICE >>> >>> ditto for spapr >>> >> Yes, had the same in mind but left it for now this way (basically >> because we do special handling for PC_DIMM, so anybody reading this code >> is not directly confused) >> > > Hmm, I think what Igor proposes is nicer. Can you send a v5 when he's > done with review?
Sure! > > Paolo > -- Thanks, David / dhildenb
