Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 152768551387.13955.7085403440722380428.stgit@pasha-ThinkPad-T60
Subject: [Qemu-devel] [RFC PATCH v1 0/2] QEMU binary instrumentation prototype
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/152768551387.13955.7085403440722380428.stgit@pasha-ThinkPad-T60 ->
patchew/152768551387.13955.7085403440722380428.stgit@pasha-ThinkPad-T60
t [tag update] patchew/20180517081527.14410-1-da...@redhat.com ->
patchew/20180517081527.14410-1-da...@redhat.com
t [tag update] patchew/20180529193730.9204-1-cr...@redhat.com ->
patchew/20180529193730.9204-1-cr...@redhat.com
Switched to a new branch 'test'
9252130de3 tcg: add instrumenting module
f845fbd7af tcg: add headers for non-target helpers
=== OUTPUT BEGIN ===
Checking PATCH 1/2: tcg: add headers for non-target helpers...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
ERROR: do not use C99 // comments
#70: FILE: include/exec/helper-register.h:53:
+#endif // HELPER_REGISTER_H
total: 1 errors, 1 warnings, 80 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/2: tcg: add instrumenting module...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25:
new file mode 100644
ERROR: do not use C99 // comments
#59: FILE: accel/tcg/instrument/instrument.c:16:
+//#define QI_ALL
ERROR: do not use C99 // comments
#72: FILE: accel/tcg/instrument/instrument.c:29:
+ // int 80h is processed by exception handlers
ERROR: trailing whitespace
#87: FILE: accel/tcg/instrument/instrument.c:44:
+#endif $
ERROR: spaces required around that '=' (ctx:VxW)
#95: FILE: accel/tcg/instrument/instrument.c:52:
+ TCGv_ptr t_cpu= tcg_const_ptr(cpu);
^
ERROR: "(foo*)" should be "(foo *)"
#111: FILE: accel/tcg/instrument/instrument.c:68:
+ CPUArchState *env = ((CPUState*)cpu)->env_ptr;
ERROR: do not use C99 // comments
#142: FILE: accel/tcg/instrument/instrument.h:11:
+#endif // INSTRUMENT_H
total: 6 errors, 1 warnings, 133 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
