On 5 June 2018 at 11:39, Pavel Dovgalyuk <pavel.dovga...@ispras.ru> wrote: > The following series implements dynamic binary instrumentation upon QEMU.
> The aim of submission of this series at that early stage is to get > the feedback which will guide the development process. We are faced > the following questions: > 1. Does every plugins should have its own callback embedded into the TB > (which will cause TB extra growth in case of multiple plugins), > or the instrumentation layer's callback should invoke the plugins > that wanted to instrument that specific instruction? > 2. How the plugins should function? Will they work as a binary dynamic > libraries or a script on some interpreted language? > 3. Should the plugins reuse QEMU configuration script results? > Now there is no possibility for using platform-specific macros > generated by QEMU configure. > 4. Maybe QEMU module infrastructure should be extended to support > plugins too? > 5. How the GDB-related CPU inspection interface may be used better? > We should pass a register code to read the value. These codes > are not described in any of the files. Maybe a function for > accessing register by name should be added? This series doesn't seem to add anything to Documentation/ that describes the API we make available to plugins. I'm a lot more interested in reviewing the API that will be used by plugins than I am in the implementation at this stage. Can you provide a description/documentation of the API for review, please? thanks -- PMM
