On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > } > > break; > > case QEMU_OPTION_preconfig: > > - preconfig_exit_requested = false; > > + if (!runstate_check(RUN_STATE_NONE)) { > > + error_report("'--preconfig' and '--incoming' options > > are " > > + "mutually exclusive"); > > + exit(EXIT_FAILURE); > > + } > > + runstate_set(RUN_STATE_PRECONFIG); > > Specifying --preconfig twice on the command line now fails with a very > cryptic message (there's no --incoming).
This can be addressed with a slight rewording "Only a single usage of --preconfig or --incoming is permitted" Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|