Philippe Mathieu-Daudé <f4...@amsat.org> writes: > Use error_report() + exit() instead of error_setg(&error_fatal), > as suggested by the "qapi/error.h" documentation: > > Please don't error_setg(&error_fatal, ...), use error_report() and > exit(), because that's more obvious. > > This fixes CID 1352173: > "Passing null pointer dt_name to qemu_fdt_node_path, which dereferences > it." > > And this also fixes: > > hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variable > 'node_path') results in a null pointer dereference > if (node_path[1]) { > ^~~~~~~~~~~~ > > Fixes: Coverity CID 1352173 (Dereference after null check) > Suggested-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Same code smell as in PATCH 4/4. Reviewed-by: Markus Armbruster <arm...@redhat.com>